Source/bindings/tests/idls/TestObject.idl - Issue 357413003: IDL: Drop redundant null check for string and wrapper type attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 357413003: IDL: Drop redundant null check for string and wrapper type attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: updated Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_attributes.py ('K') | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/TestObject.idl

diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl

index 11ee22a04a8e4ed5f74d9586de6fd0006396d86b..0bdde396ed3d830a978aecc6c38546e82cdb9929 100644

--- a/Source/bindings/tests/idls/TestObject.idl

+++ b/Source/bindings/tests/idls/TestObject.idl

@@ -163,6 +163,7 @@ interface TestObject {

[LogActivity=SetterOnly, LogAllWorlds] attribute long activityLoggingSetterForAllWorldsLongAttribute;

[CachedAttribute=isValueDirty] attribute any cachedAttributeAnyAttribute;

[CachedAttribute=isArrayDirty] attribute DOMString[] cachedArrayAttribute;

+ [CachedAttribute=isStringDirty] attribute DOMString? cachedStringOrNoneAttribute;

[CallWith=ExecutionContext] attribute any callWithExecutionContextAnyAttribute;

[CallWith=ScriptState] attribute any callWithScriptStateAnyAttribute;

[CallWith=ExecutionContext|ScriptState] attribute any callWithExecutionContextAndScriptStateAnyAttribute;

@@ -242,6 +243,7 @@ interface TestObject {

[TreatNullAs=NullString] attribute DOMString treatNullAsNullStringStringAttribute;

[TreatReturnedNullStringAs=Null] attribute DOMString treatReturnedNullStringAsNullStringAttribute;

[TreatReturnedNullStringAs=Undefined] attribute DOMString treatReturnedNullStringAsUndefinedStringAttribute;

+ [TreatReturnedNullStringAs=Undefined, CachedAttribute=isStringDirty] attribute DOMString cachedTreatReturnedNullStringAsUndefinedStringAttribute;

[TreatReturnedNullStringAs=Null] attribute ByteString treatReturnedNullStringAsNullByteStringAttribute;

[TreatReturnedNullStringAs=Undefined] attribute ByteString treatReturnedNullStringAsUndefinedByteStringAttribute;

[TreatReturnedNullStringAs=Null] attribute ScalarValueString treatReturnedNullStringAsNullScalarValueStringAttribute;

@@ -252,7 +254,7 @@ interface TestObject {

[Reflect, URL] attribute DOMString urlStringAttribute;

[Reflect=reflectUrlAttribute, URL] attribute DOMString urlStringAttribute;

[Unforgeable] attribute long unforgeableLongAttribute;

- [LogActivity=SetterOnly, LogPreviousValue] attribute long activityLoggingSetterOnlyLogPreviousValueAttribute;

+ [LogActivity=SetterOnly, LogPreviousValue] attribute DOMString? activityLoggingSetterOnlyLogPreviousValueAttribute;

[LogActivity, LogPreviousValue] attribute TestInterfaceEmpty activityLoggingLogPreviousValueInterfaceAttribute;