Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/bindings/tests/idls/TestObject.idl

Issue 357413003: IDL: Drop redundant null check for string and wrapper type attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: updated Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 static attribute long staticLongAttribute; 156 static attribute long staticLongAttribute;
157 // Exceptional type 157 // Exceptional type
158 attribute EventHandler eventHandlerAttribute; 158 attribute EventHandler eventHandlerAttribute;
159 159
160 // Extended attributes 160 // Extended attributes
161 [LogActivity, LogAllWorlds] attribute long activityLoggingAccessForAllWorlds LongAttribute; 161 [LogActivity, LogAllWorlds] attribute long activityLoggingAccessForAllWorlds LongAttribute;
162 [LogActivity=GetterOnly, LogAllWorlds] attribute long activityLoggingGetterF orAllWorldsLongAttribute; 162 [LogActivity=GetterOnly, LogAllWorlds] attribute long activityLoggingGetterF orAllWorldsLongAttribute;
163 [LogActivity=SetterOnly, LogAllWorlds] attribute long activityLoggingSetterF orAllWorldsLongAttribute; 163 [LogActivity=SetterOnly, LogAllWorlds] attribute long activityLoggingSetterF orAllWorldsLongAttribute;
164 [CachedAttribute=isValueDirty] attribute any cachedAttributeAnyAttribute; 164 [CachedAttribute=isValueDirty] attribute any cachedAttributeAnyAttribute;
165 [CachedAttribute=isArrayDirty] attribute DOMString[] cachedArrayAttribute; 165 [CachedAttribute=isArrayDirty] attribute DOMString[] cachedArrayAttribute;
166 [CachedAttribute=isStringDirty] attribute DOMString? cachedStringOrNoneAttri bute;
166 [CallWith=ExecutionContext] attribute any callWithExecutionContextAnyAttribu te; 167 [CallWith=ExecutionContext] attribute any callWithExecutionContextAnyAttribu te;
167 [CallWith=ScriptState] attribute any callWithScriptStateAnyAttribute; 168 [CallWith=ScriptState] attribute any callWithScriptStateAnyAttribute;
168 [CallWith=ExecutionContext|ScriptState] attribute any callWithExecutionConte xtAndScriptStateAnyAttribute; 169 [CallWith=ExecutionContext|ScriptState] attribute any callWithExecutionConte xtAndScriptStateAnyAttribute;
169 [CheckSecurity=Node] readonly attribute Document checkSecurityForNodeReadonl yDocumentAttribute; // All uses are read only 170 [CheckSecurity=Node] readonly attribute Document checkSecurityForNodeReadonl yDocumentAttribute; // All uses are read only
170 [Conditional=CONDITION] attribute long conditionalLongAttribute; 171 [Conditional=CONDITION] attribute long conditionalLongAttribute;
171 [Conditional=CONDITION_1&CONDITION_2] attribute long conditionalAndLongAttri bute; 172 [Conditional=CONDITION_1&CONDITION_2] attribute long conditionalAndLongAttri bute;
172 [Conditional=CONDITION_1|CONDITION_2] attribute long conditionalOrLongAttrib ute; 173 [Conditional=CONDITION_1|CONDITION_2] attribute long conditionalOrLongAttrib ute;
173 // Constructors: FIXME: replace suffix with [ConstructorAttribute] 174 // Constructors: FIXME: replace suffix with [ConstructorAttribute]
174 attribute TestInterfaceEmptyConstructor testInterfaceEmptyConstructorAttribu te; 175 attribute TestInterfaceEmptyConstructor testInterfaceEmptyConstructorAttribu te;
175 [DeprecateAs=deprecatedTestInterfaceEmptyConstructorAttribute] attribute Tes tInterfaceEmptyConstructor testInterfaceEmptyConstructorAttribute; 176 [DeprecateAs=deprecatedTestInterfaceEmptyConstructorAttribute] attribute Tes tInterfaceEmptyConstructor testInterfaceEmptyConstructorAttribute;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 [Replaceable] readonly attribute long replaceableReadonlyLongAttribute; 236 [Replaceable] readonly attribute long replaceableReadonlyLongAttribute;
236 [Replaceable, PutForwards=href] readonly attribute TestNode locationReplacea ble; 237 [Replaceable, PutForwards=href] readonly attribute TestNode locationReplacea ble;
237 [RuntimeEnabled=FeatureName] attribute long runtimeEnabledLongAttribute; 238 [RuntimeEnabled=FeatureName] attribute long runtimeEnabledLongAttribute;
238 [PerContextEnabled=FeatureName, RuntimeEnabled=FeatureName] attribute long p erContextEnabledRuntimeEnabledLongAttribute; 239 [PerContextEnabled=FeatureName, RuntimeEnabled=FeatureName] attribute long p erContextEnabledRuntimeEnabledLongAttribute;
239 [Conditional=CONDITION, RuntimeEnabled=FeatureName] attribute long condition alRuntimeEnabledLongAttribute; 240 [Conditional=CONDITION, RuntimeEnabled=FeatureName] attribute long condition alRuntimeEnabledLongAttribute;
240 [SetterCallWith=ActiveWindow&FirstWindow] attribute DOMString setterCallWith ActiveWindowAndFirstWindowStringAttribute; 241 [SetterCallWith=ActiveWindow&FirstWindow] attribute DOMString setterCallWith ActiveWindowAndFirstWindowStringAttribute;
241 [SetterCallWith=ExecutionContext] attribute DOMString setterCallWithExecutio nContextStringAttribute; 242 [SetterCallWith=ExecutionContext] attribute DOMString setterCallWithExecutio nContextStringAttribute;
242 [TreatNullAs=NullString] attribute DOMString treatNullAsNullStringStringAttr ibute; 243 [TreatNullAs=NullString] attribute DOMString treatNullAsNullStringStringAttr ibute;
243 [TreatReturnedNullStringAs=Null] attribute DOMString treatReturnedNullString AsNullStringAttribute; 244 [TreatReturnedNullStringAs=Null] attribute DOMString treatReturnedNullString AsNullStringAttribute;
244 [TreatReturnedNullStringAs=Undefined] attribute DOMString treatReturnedNullS tringAsUndefinedStringAttribute; 245 [TreatReturnedNullStringAs=Undefined] attribute DOMString treatReturnedNullS tringAsUndefinedStringAttribute;
246 [TreatReturnedNullStringAs=Undefined, CachedAttribute=isStringDirty] attribu te DOMString cachedTreatReturnedNullStringAsUndefinedStringAttribute;
245 [TreatReturnedNullStringAs=Null] attribute ByteString treatReturnedNullStrin gAsNullByteStringAttribute; 247 [TreatReturnedNullStringAs=Null] attribute ByteString treatReturnedNullStrin gAsNullByteStringAttribute;
246 [TreatReturnedNullStringAs=Undefined] attribute ByteString treatReturnedNull StringAsUndefinedByteStringAttribute; 248 [TreatReturnedNullStringAs=Undefined] attribute ByteString treatReturnedNull StringAsUndefinedByteStringAttribute;
247 [TreatReturnedNullStringAs=Null] attribute ScalarValueString treatReturnedNu llStringAsNullScalarValueStringAttribute; 249 [TreatReturnedNullStringAs=Null] attribute ScalarValueString treatReturnedNu llStringAsNullScalarValueStringAttribute;
248 [TreatReturnedNullStringAs=Undefined] attribute ScalarValueString treatRetur nedNullStringAsUndefinedScalarValueStringAttribute; 250 [TreatReturnedNullStringAs=Undefined] attribute ScalarValueString treatRetur nedNullStringAsUndefinedScalarValueStringAttribute;
249 [TypeChecking=Interface] attribute float typeCheckingInterfaceFloatAttribute ; // nop for non-interface types 251 [TypeChecking=Interface] attribute float typeCheckingInterfaceFloatAttribute ; // nop for non-interface types
250 [TypeChecking=Interface] attribute TestInterface typeCheckingInterfaceTestIn terfaceAttribute; 252 [TypeChecking=Interface] attribute TestInterface typeCheckingInterfaceTestIn terfaceAttribute;
251 [TypeChecking=Interface] attribute TestInterface? typeCheckingInterfaceTestI nterfaceOrNullAttribute; 253 [TypeChecking=Interface] attribute TestInterface? typeCheckingInterfaceTestI nterfaceOrNullAttribute;
252 [Reflect, URL] attribute DOMString urlStringAttribute; 254 [Reflect, URL] attribute DOMString urlStringAttribute;
253 [Reflect=reflectUrlAttribute, URL] attribute DOMString urlStringAttribute; 255 [Reflect=reflectUrlAttribute, URL] attribute DOMString urlStringAttribute;
254 [Unforgeable] attribute long unforgeableLongAttribute; 256 [Unforgeable] attribute long unforgeableLongAttribute;
255 [LogActivity=SetterOnly, LogPreviousValue] attribute long activityLoggingSet terOnlyLogPreviousValueAttribute; 257 [LogActivity=SetterOnly, LogPreviousValue] attribute DOMString? activityLogg ingSetterOnlyLogPreviousValueAttribute;
256 [LogActivity, LogPreviousValue] attribute TestInterfaceEmpty activityLogging LogPreviousValueInterfaceAttribute; 258 [LogActivity, LogPreviousValue] attribute TestInterfaceEmpty activityLogging LogPreviousValueInterfaceAttribute;
257 259
258 260
259 // Methods 261 // Methods
260 // 262 //
261 // Naming convention: 263 // Naming convention:
262 // ReturnType returnTypeMethodTypeName1ArgTypeName2Arg(Type1 typeName1Arg, T ype2 typeName2Arg); 264 // ReturnType returnTypeMethodTypeName1ArgTypeName2Arg(Type1 typeName1Arg, T ype2 typeName2Arg);
263 // E.g., 265 // E.g.,
264 // void voidMethodStringArgLongArrayArg(DOMString stringArg, long[] longArra yArg); 266 // void voidMethodStringArgLongArrayArg(DOMString stringArg, long[] longArra yArg);
265 void voidMethod(); 267 void voidMethod();
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 void voidMethodTestInterfaceWillBeGarbageCollectedArrayArg(TestInterfaceWill BeGarbageCollected[] testInterfaceWillBeGarbageCollectedArrayArg); 522 void voidMethodTestInterfaceWillBeGarbageCollectedArrayArg(TestInterfaceWill BeGarbageCollected[] testInterfaceWillBeGarbageCollectedArrayArg);
521 523
522 // Extended attributes on referenced interfaces 524 // Extended attributes on referenced interfaces
523 // (not self; self-reference tests at interface themselves) 525 // (not self; self-reference tests at interface themselves)
524 attribute TestInterface testInterfaceAttribute; // [ImplementedAs] 526 attribute TestInterface testInterfaceAttribute; // [ImplementedAs]
525 attribute TestInterfaceGarbageCollected testInterfaceGarbageCollectedAttribu te; // [GarbageCollected] 527 attribute TestInterfaceGarbageCollected testInterfaceGarbageCollectedAttribu te; // [GarbageCollected]
526 attribute TestInterfaceGarbageCollected? testInterfaceGarbageCollectedOrNull Attribute; // [GarbageCollected] 528 attribute TestInterfaceGarbageCollected? testInterfaceGarbageCollectedOrNull Attribute; // [GarbageCollected]
527 attribute TestInterfaceWillBeGarbageCollected testInterfaceWillBeGarbageColl ectedAttribute; // [WillBeGarbageCollected] 529 attribute TestInterfaceWillBeGarbageCollected testInterfaceWillBeGarbageColl ectedAttribute; // [WillBeGarbageCollected]
528 attribute TestInterfaceWillBeGarbageCollected? testInterfaceWillBeGarbageCol lectedOrNullAttribute; // [WillBeGarbageCollected] 530 attribute TestInterfaceWillBeGarbageCollected? testInterfaceWillBeGarbageCol lectedOrNullAttribute; // [WillBeGarbageCollected]
529 }; 531 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698