IDL: Drop redundant null check for string and wrapper type attributes

Source/bindings/scripts/v8_attributes.py

Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index c9d64402af6f4b457c2bf1ca0e35970a4825b631..86db49252e792ec216bbd7a8d5de29c8b904b856 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -94,7 +94,6 @@ def attribute_context(interface, attribute):
                             if is_constructor_attribute(attribute) else None,
         'cpp_name': cpp_name(attribute),
         'cpp_type': idl_type.cpp_type,
-        'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(cpp_value='original', creation_context='info.Holder()'),
         'deprecate_as': v8_utilities.deprecate_as(attribute),  # [DeprecateAs]
         'enum_validation_expression': idl_type.enum_validation_expression,
         'has_custom_getter': has_custom_getter,
@@ -170,9 +169,10 @@ def getter_context(interface, attribute, context):
     # FIXME: check if compilers are smart enough to inline this, and if so,
     # always use a local variable (for readability and CG simplicity).
     release = False
-    if (idl_type.is_nullable or
+    if ((idl_type.is_nullable and not context['is_nullable_simple']) or
         base_idl_type == 'EventHandler' or
         'CachedAttribute' in extended_attributes or
+        'LogPreviousValue' in extended_attributes or

[Jens Widell, 2014/07/01 06:43:22]

Added this to avoid the [LogPreviousValue] code calling the C++ getter multiple
times. It'll lead to redundant use of a local variable in the corresponding
getter instead, but that's fine I think.

Attributes with [LogPreviousValue] are rare anyway.

[haraken, 2014/07/01 06:47:17]

Yes, we're deprecating it with pmarch@.

         'ReflectOnly' in extended_attributes or
         context['is_keep_alive_for_gc'] or
         context['is_getter_raises_exception']):
@@ -189,7 +189,9 @@ def getter_context(interface, attribute, context):
 
     context.update({
         'cpp_value': cpp_value,
-        'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(cpp_value=cpp_value, creation_context='info.Holder()'),
+        'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(
+            cpp_value=cpp_value, creation_context='info.Holder()',
+            extended_attributes=extended_attributes),

[Jens Widell, 2014/07/01 06:43:23]

Passing 'extended_attributes' here since it affects
v8_types.v8_conversion_type().

         'v8_set_return_value_for_main_world': v8_set_return_value_statement(for_main_world=True),
         'v8_set_return_value': v8_set_return_value_statement(),
     })