Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 357213002: setConfig is deprecated, use setInfo or allocPixels instead (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

setConfig is deprecated, use setInfo or allocPixels instead kPMColor_SkColorType -> kN32_SkColorType TBR=scherkus@chromium.org,benwells@chromium.org BUG=skia:2706 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280805

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M components/favicon_base/favicon_util.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/favicon_base/select_favicon_frames.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/set_icon_natives.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/skcanvas_video_renderer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
reed1
6 years, 5 months ago (2014-06-29 03:03:27 UTC) #1
f(malita)
lgtm, but you'll need some more owners.
6 years, 5 months ago (2014-06-30 00:50:43 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-30 15:20:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/357213002/20001
6 years, 5 months ago (2014-06-30 15:21:23 UTC) #4
reed1
+ owners should be a pure renaming CL
6 years, 5 months ago (2014-06-30 15:22:43 UTC) #5
reed1
On 2014/06/30 15:22:43, reed1 wrote: > + owners > > should be a pure renaming ...
6 years, 5 months ago (2014-06-30 15:23:50 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-06-30 19:19:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 19:23:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77222)
6 years, 5 months ago (2014-06-30 19:23:18 UTC) #9
reed2
ping - need owners for components/ extensions/ media/
6 years, 5 months ago (2014-07-01 00:06:31 UTC) #10
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-01 07:26:47 UTC) #11
reed2
The CQ bit was checked by reed@chromium.org
6 years, 5 months ago (2014-07-01 09:48:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/357213002/20001
6 years, 5 months ago (2014-07-01 09:49:18 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-01 11:29:53 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 11:32:33 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77351)
6 years, 5 months ago (2014-07-01 11:32:34 UTC) #16
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-01 12:59:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/357213002/20001
6 years, 5 months ago (2014-07-01 12:59:29 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 13:03:08 UTC) #19
Message was sent while issue was closed.
Change committed as 280805

Powered by Google App Engine
This is Rietveld 408576698