media/filters/skcanvas_video_renderer.cc - Issue 357213002: setConfig is deprecated, use setInfo or allocPixels instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/skcanvas_video_renderer.cc

Issue 357213002: setConfig is deprecated, use setInfo or allocPixels instead (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/skcanvas_video_renderer.cc

diff --git a/media/filters/skcanvas_video_renderer.cc b/media/filters/skcanvas_video_renderer.cc

index 0f5dd0ecdbba6622b8caf137a319a877751e97cd..53a9fb9426401d32a62abc098df4a58140d1defc 100644

--- a/media/filters/skcanvas_video_renderer.cc

+++ b/media/filters/skcanvas_video_renderer.cc

@@ -56,10 +56,8 @@ static void ConvertVideoFrameToBitmap(

if (bitmap->isNull() ||

bitmap->width() != video_frame->visible_rect().width() ||

bitmap->height() != video_frame->visible_rect().height()) {

- bitmap->setConfig(SkBitmap::kARGB_8888_Config,

- video_frame->visible_rect().width(),

- video_frame->visible_rect().height());

- bitmap->allocPixels();

+ bitmap->allocN32Pixels(video_frame->visible_rect().width(),

+ video_frame->visible_rect().height());

bitmap->setIsVolatile(true);

}