extensions/renderer/set_icon_natives.cc - Issue 357213002: setConfig is deprecated, use setInfo or allocPixels instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/set_icon_natives.cc

Issue 357213002: setConfig is deprecated, use setInfo or allocPixels instead (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/set_icon_natives.cc

diff --git a/extensions/renderer/set_icon_natives.cc b/extensions/renderer/set_icon_natives.cc

index 2ef12dcfb84f74f59c21dd4da366124dc7c8d14c..192112f1d812215e823bbf4929e716d412b3ebed 100644

--- a/extensions/renderer/set_icon_natives.cc

+++ b/extensions/renderer/set_icon_natives.cc

@@ -68,8 +68,7 @@ bool SetIconNatives::ConvertImageDataToBitmapValue(

}

SkBitmap bitmap;

- bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, height);

- if (!bitmap.allocPixels()) {

+ if (!bitmap.allocN32Pixels(width, height)) {

isolate->ThrowException(

v8::Exception::Error(v8::String::NewFromUtf8(isolate, kNoMemory)));

return false;