Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 356843007: Remove meaningless uses of [TypeChecking=Nullable] (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, shans, eae+blinkwatch, fs, eric.carlson_apple.com, aandrey+blink_chromium.org, rwlbuis, Steve Block, arv+blink, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Timothy Loh, dstockwell, dglazkov+blink, Rik, pdr., Eric Willigers, philipj_slow, rjwright, sof, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, krit, gyuyoung.kim_webkit.org, darktears, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove meaningless uses of [TypeChecking=Nullable] [TypeChecking=Nullable] only serves a purpose on nullable attributes. Using it on interfaces without nullable attributes, or methods (even those with nullable arguments) serves no purpose. Using it on individual arguments also serves no purpose; in fact, the [TypeChecking] extended attribute is not supported at all on arguments. This patch does not change any generated code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M Source/core/animation/Timing.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/ANGLEInstancedArrays.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/DataView.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/EXTBlendMinMax.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Path2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLLoseContext.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/Selection.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAngle.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedEnumeration.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedInteger.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGeometryElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLength.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMatrix.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumber.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumberList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegArcRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPoint.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPointList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRect.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStringList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransform.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransformList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/WindowImageBitmapFactories.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/URLMediaSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
This leaves a grand total of 4 uses of TypeChecking=Nullable in the code. They are ...
6 years, 5 months ago (2014-06-27 13:25:03 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-06-27 14:02:10 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-27 14:05:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/356843007/1
6 years, 5 months ago (2014-06-27 14:05:51 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 15:14:50 UTC) #5
Message was sent while issue was closed.
Change committed as 177108

Powered by Google App Engine
This is Rietveld 408576698