Satisfy new -Wunused-local-typedefs in gcc 4.8 in the simulators.

Satisfy new -Wunused-local-typedefs in gcc 4.8 in the simulators.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37823

[zra, 2014-06-27 21:23:19]

I hate to ask for changes after you've already gone through the trouble of
adding this annotation everywhere, but maybe for arm64 and/or mips it would be
easy to do a find/replace to change the whole sequence in ASSEMBLER_TEST_RUN to
a macro, e.g.:

#define INT64_RUN(expected) \
  typedef int64_t (*Int64Return)() DART_UNUSED; \
  EXPECT_EQ(expected, EXECUTE_TEST_CODE_INT64(Int64Return, test->entry()));

etc.

That way, in the future, we can remove DART_UNUSED a bit more easily if clang
ever supports -fno-unused-typedefs.

[rmacnak, 2014-06-27 22:19:12]

By itself that replacement is simple enough, but to do a similar one for doubles
is awkward because the tests aren't all for plain equality or even all for
equality with a tolerance, so we'd still be left DART_UNUSED littered about. I
think leaving the change as it is now would be actually make it easier to remove
later because it's a simple match for DART_UNUSED in these files.

On 2014/06/27 21:23:19, zra wrote:
> I hate to ask for changes after you've already gone through the trouble of
> adding this annotation everywhere, but maybe for arm64 and/or mips it would be
> easy to do a find/replace to change the whole sequence in ASSEMBLER_TEST_RUN
to
> a macro, e.g.:
> 
> #define INT64_RUN(expected) \
>   typedef int64_t (*Int64Return)() DART_UNUSED; \
>   EXPECT_EQ(expected, EXECUTE_TEST_CODE_INT64(Int64Return, test->entry()));
> 
> etc.
> 
> That way, in the future, we can remove DART_UNUSED a bit more easily if clang
> ever supports -fno-unused-typedefs.

[zra, 2014-06-30 14:28:55]

lgtm

Ah, right. Doubles. May as well leave them all the same, then.

[rmacnak, 2014-06-30 17:03:03]

Committed patchset #2 manually as r37823 (presubmit successful).