Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 354953002: Promisify Service Worker test unregister_and_register helper function (Closed)

Created:
6 years, 6 months ago by falken
Modified:
6 years, 6 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Promisify Service Worker test unregister_and_register helper function Service Worker API is promise-based, so this helper should be too. Also take care of a FIXME now that testharness has been updated. BUG= R=horo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177030

Patch Set 1 #

Patch Set 2 : step_func #

Patch Set 3 : add step_func for safety #

Patch Set 4 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M LayoutTests/http/tests/serviceworker/activation-after-registration.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/controller-on-load.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-event.html View 1 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/indexeddb.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-to-client.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ready-controlled-document.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-end-to-end.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-events.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/request-end-to-end.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html View 1 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/state.html View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
falken
PTAL
6 years, 6 months ago (2014-06-26 03:41:02 UTC) #1
horo
lgtm
6 years, 6 months ago (2014-06-26 06:26:27 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 6 months ago (2014-06-26 06:34:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/354953002/40001
6 years, 6 months ago (2014-06-26 06:36:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-26 07:37:43 UTC) #5
falken
6 years, 6 months ago (2014-06-27 00:49:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r177030 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698