LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html - Issue 354953002: Promisify Service Worker test unregister_and_register helper function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html

Issue 354953002: Promisify Service Worker test unregister_and_register helper function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/test-helpers.js ('k') | LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html

diff --git a/LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html b/LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html

index c2a3e3aa364adb0f8d86b60da410c1574e6bb673..3a7c6774d8e1f16415d0c5936beff7b57fb613c0 100644

--- a/LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html

+++ b/LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope.html

@@ -17,8 +17,9 @@ function scope_test(name, scope) {

}

service_worker_unregister_and_register(

- t, 'resources/serviceworkerglobalscope-scope-worker.js', scope,

- function(worker) {

+ t, 'resources/serviceworkerglobalscope-scope-worker.js', scope

+ ).then(

+ t.step_func(function(worker) {

var messageChannel = new MessageChannel();

messageChannel.port1.onmessage = t.step_func(function(e) {

message = e.data;

@@ -27,7 +28,8 @@ function scope_test(name, scope) {

service_worker_unregister_and_done(t, scope);

});

worker.postMessage('', [messageChannel.port2]);

- });

+ })

+ );

});

}