Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/test-helpers.js

Issue 354953002: Promisify Service Worker test unregister_and_register helper function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/resources/test-helpers.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
index 627e63d2a666d849322c423ebfc3785add9306ed..2ded3ec4e0e0c01b29a6b358a4dd32b1acf4ec4b 100644
--- a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
+++ b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
@@ -4,7 +4,7 @@ function service_worker_test(url, description) {
var t = async_test(description);
t.step(function() {
var scope = 'nonexistent';
- service_worker_unregister_and_register(t, url, scope, onRegistered);
+ service_worker_unregister_and_register(t, url, scope).then(t.step_func(onRegistered));
function onRegistered(worker) {
var messageChannel = new MessageChannel();
@@ -19,16 +19,16 @@ function service_worker_test(url, description) {
});
}
-function service_worker_unregister_and_register(test, url, scope, onregister) {
+function service_worker_unregister_and_register(test, url, scope) {
var options = scope ? { scope: scope } : {};
return navigator.serviceWorker.unregister(scope).then(
- // FIXME: Wrap this with test.step_func once testharness.js is updated.
- function() {
+ test.step_func(function() {
return navigator.serviceWorker.register(url, options);
- },
+ }),
unreached_rejection(test, 'Unregister should not fail')
- ).then(
- test.step_func(onregister),
+ ).then(test.step_func(function(worker) {
+ return Promise.resolve(worker);
+ }),
unreached_rejection(test, 'Registration should not fail')
);
}

Powered by Google App Engine
This is Rietveld 408576698