Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 354863003: [Android] Switch to DeviceUtils versions of GoHome, ForceStop, etc. (Closed)

Created:
6 years, 6 months ago by jbudorick
Modified:
6 years, 6 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch to DeviceUtils versions of GoHome, ForceStop, etc. (etc: ClearApplicationState and SendKeyEvent) BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279933

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -6 lines) Patch
M build/android/pylib/device/device_utils.py View 1 1 chunk +45 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +35 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbudorick
6 years, 6 months ago (2014-06-25 16:31:01 UTC) #1
jbudorick
+tonyg for telemetry
6 years, 6 months ago (2014-06-25 16:31:28 UTC) #2
tonyg
lgtm
6 years, 6 months ago (2014-06-25 16:33:30 UTC) #3
frankf
lgtm https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py#newcode395 build/android/pylib/device/device_utils.py:395: """ Return to the home screen. remove space ...
6 years, 6 months ago (2014-06-25 19:19:31 UTC) #4
Victor Starodub
lgtm https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py#newcode409 build/android/pylib/device/device_utils.py:409: timeout: Same as for |IsOnline|. Maybe expand these? ...
6 years, 6 months ago (2014-06-25 19:35:45 UTC) #5
jbudorick
On 2014/06/25 19:35:45, Victor Starodub wrote: > lgtm > > https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py > File build/android/pylib/device/device_utils.py (right): ...
6 years, 6 months ago (2014-06-25 20:36:43 UTC) #6
jbudorick
https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/354863003/diff/1/build/android/pylib/device/device_utils.py#newcode395 build/android/pylib/device/device_utils.py:395: """ Return to the home screen. On 2014/06/25 19:19:30, ...
6 years, 6 months ago (2014-06-25 21:04:28 UTC) #7
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 6 months ago (2014-06-25 23:13:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/354863003/20001
6 years, 6 months ago (2014-06-25 23:15:00 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 06:38:45 UTC) #10
Message was sent while issue was closed. 
Change committed as 279933

Powered by Google App Engine
This is Rietveld 408576698