tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py - Issue 354863003: [Android] Switch to DeviceUtils versions of GoHome, ForceStop, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

Issue 354863003: [Android] Switch to DeviceUtils versions of GoHome, ForceStop, etc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

index 1dd5e6e9e00f5a0d9140cfa869e8fe8f8a966e88..98602fe3b2392bca93ca4a9413b2ff47e83e883d 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

@@ -35,7 +35,7 @@ class OOMKillerProfiler(profiler.Profiler):

assert mem_consumer_path, ('Could not find memconsumer app. Please build '

'memconsumer target.')

self._browser_backend.adb.Install(mem_consumer_path)

- self._browser_backend.adb.GoHome()

+ self._browser_backend.adb.device().GoHome()

self._platform_backend.LaunchApplication(

'org.chromium.memconsumer/.MemConsumer',

'--ei memory 20')

@@ -57,7 +57,7 @@ class OOMKillerProfiler(profiler.Profiler):

@classmethod

def WillCloseBrowser(cls, browser_backend, platform_backend):

- browser_backend.adb.CloseApplication('org.chromium.memconsumer')

+ browser_backend.adb.device().ForceStop('org.chromium.memconsumer')

def CollectProfile(self):

missing_applications = self._MissingApplications()

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('k') | no next file » | no next file with comments »