tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py - Issue 354863003: [Android] Switch to DeviceUtils versions of GoHome, ForceStop, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 354863003: [Android] Switch to DeviceUtils versions of GoHome, ForceStop, etc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/uiautomator/test_runner.py ('k') | tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

index 0d6046495c075f9128dde5f4e1148f8ea06c82df..9a2bc82fb7884727e97e4ad4625d576afa54cfd5 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

@@ -188,7 +188,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._port = adb_commands.AllocateTestServerPort()

# Kill old browser.

- self._adb.CloseApplication(self._backend_settings.package)

+ self._adb.device().ForceStop(self._backend_settings.package)

if self._adb.device().old_interface.CanAccessProtectedFileContents():

if self.browser_options.profile_dir:

@@ -357,7 +357,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

def Close(self):

super(AndroidBrowserBackend, self).Close()

- self._adb.CloseApplication(self._backend_settings.package)

+ self._adb.device().ForceStop(self._backend_settings.package)

if self._output_profile_path:

logging.info("Pulling profile directory from device: '%s'->'%s'.",