Issue 354663002: Make GrGLShaderBuilder::fragmentPosition() return a vec4, with 1.0 as the zw components when in the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354663002: Make GrGLShaderBuilder::fragmentPosition() return a vec4, with 1.0 as the zw components when in the… (Closed)

Created:
6 years, 6 months ago by bsalomon

Modified:
6 years, 6 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Make GrGLShaderBuilder::fragmentPosition() return a vec4, with 1.0 as the zw components when in the y-flip case. This works around an Adreno driver bug. Revert "Stop referencing gl_FragCoord z and w components." This reverts commit 160a52ba217012ed73c240f6d67b3bbf2b4879d6. Committed: https://skia.googlesource.com/skia/+/22900008fb89afe4687a40db8737553ee0e55621

Patch Set 1 #

Patch Set 2 : line wraps #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -14 lines)			Patch
M	src/effects/SkBlurMaskFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrDitherEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrOvalEffect.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrRRectEffect.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

The previous workaround did not actually work. This reverts it, going back to returning a ...

6 years, 6 months ago (2014-06-24 17:56:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/354663002/20001

6 years, 6 months ago (2014-06-24 18:01:21 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-24 18:16:56 UTC) #5

Message was sent while issue was closed.

Change committed as 22900008fb89afe4687a40db8737553ee0e55621

Expand Messages | Collapse Messages