Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 354533004: Begin atlasing (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Begin atlasing This CL makes it possible for pulled-forward-layers to be atlased. It currently has a couple glaring limitations (which is why it is disabled): 1) the atlased layers cannot be purged nor aged out 2) the texture backing the atlas is not pulled from (or returned to) the resource cache #1 is on hold until we have a recycling rectanizer A separate major limitation (the non-atlased layers aren't cached) is blocked until we can transmute entries in the resource cache from scratch to non-scratch while potentially preserving their contents. Committed: https://skia.googlesource.com/skia/+/55e61f0ef4e5c8c34ac107deaadc9b4ffef3111b Committed: https://skia.googlesource.com/skia/+/952841bf41a81228c23d16c7204b458abe0d7136

Patch Set 1 #

Patch Set 2 : Fix merge error #

Patch Set 3 : Next step #

Patch Set 4 : cleanup #

Patch Set 5 : New version #

Patch Set 6 : fix unit test #

Total comments: 1

Patch Set 7 : Add RenderTarget-specific flags to SkSurface #

Patch Set 8 : Revert accidentally checked in files #

Patch Set 9 : Remove use of deprecated entry point #

Patch Set 10 : Fix memory leak #

Patch Set 11 : Readd missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -93 lines) Patch
M gyp/tests.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkSurface.h View 1 2 3 4 5 6 2 chunks +15 lines, -3 lines 0 comments Download
M include/gpu/GrRect.h View 2 chunks +19 lines, -0 lines 0 comments Download
M src/core/SkPicturePlayback.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/GrAtlas.h View 1 2 3 4 2 chunks +16 lines, -11 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 2 3 4 5 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 2 3 4 5 5 chunks +29 lines, -42 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +85 lines, -12 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +45 lines, -5 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 3 4 5 6 5 chunks +18 lines, -13 lines 0 comments Download
A tests/GpuLayerCacheTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +137 lines, -0 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-26 19:26:24 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/354533004/diff/100001/include/core/SkSurface.h File include/core/SkSurface.h (right): https://codereview.chromium.org/354533004/diff/100001/include/core/SkSurface.h#newcode77 include/core/SkSurface.h:77: bool clear = true); should be make this ...
6 years, 6 months ago (2014-06-26 20:37:29 UTC) #2
robertphillips
PLA @ PS 7. It contains the new flags.
6 years, 5 months ago (2014-06-27 17:11:38 UTC) #3
robertphillips
PLA -> PTAL
6 years, 5 months ago (2014-06-27 17:22:30 UTC) #4
bsalomon
On 2014/06/27 17:22:30, robertphillips wrote: > PLA -> PTAL lgtm
6 years, 5 months ago (2014-06-27 20:19:26 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-06-29 21:52:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/354533004/160001
6 years, 5 months ago (2014-06-29 21:53:55 UTC) #7
commit-bot: I haz the power
Change committed as 55e61f0ef4e5c8c34ac107deaadc9b4ffef3111b
6 years, 5 months ago (2014-06-29 22:08:36 UTC) #8
robertphillips
A revert of this CL has been created in https://codereview.chromium.org/359953002/ by robertphillips@google.com. The reason for ...
6 years, 5 months ago (2014-06-30 00:03:59 UTC) #9
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-06-30 14:50:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/354533004/180001
6 years, 5 months ago (2014-06-30 14:51:19 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-30 14:59:42 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 15:01:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/515)
6 years, 5 months ago (2014-06-30 15:01:14 UTC) #14
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-06-30 15:11:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/354533004/200001
6 years, 5 months ago (2014-06-30 15:12:22 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 15:26:58 UTC) #17
Message was sent while issue was closed.
Change committed as 952841bf41a81228c23d16c7204b458abe0d7136

Powered by Google App Engine
This is Rietveld 408576698