Chromium Code Reviews
Help | Chromium Project | Sign in
(896)

Issue 354002: Sixth patch in getting rid of caching MessageLoop pointers. Audio and automa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by jam
Modified:
2 years, 10 months ago
Reviewers:
Alpha
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin, ben+cc_chromium.org, jam, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Sixth patch in getting rid of caching MessageLoop pointers.

BUG=25354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30737

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -62 lines) Lint Patch
M chrome/browser/automation/automation_resource_message_filter.h View 2 chunks +0 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/automation/automation_resource_message_filter.cc View 7 chunks +14 lines, -14 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/audio_renderer_host.h View 1 2 3 4 chunks +1 line, -6 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/audio_renderer_host.cc View 1 2 3 17 chunks +30 lines, -33 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/audio_renderer_host_unittest.cc View 4 5 chunks +10 lines, -5 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
jam
4 years, 5 months ago #1
Alpha
LGTM. One question, what is the intention of removing reference to MessageLoop? Is it that ...
4 years, 5 months ago #2
jam
4 years, 5 months ago #3
On Mon, Nov 2, 2009 at 10:52 AM, <hclam@chromium.org> wrote:

> LGTM.
>
> One question, what is the intention of removing reference to MessageLoop?
> Is it
> that we shouldn't be using MessageLoop directly?


Correct.  I'm sending out an email today to chromium-dev with the nitty
gritty details (perhaps I should have sent it first!).

>
>
> http://codereview.chromium.org/354002
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6