Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Issue 354002: Sixth patch in getting rid of caching MessageLoop pointers. Audio and automa... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/audio_renderer_host_unittest.cc
===================================================================
--- chrome/browser/renderer_host/audio_renderer_host_unittest.cc (revision 30691)
+++ chrome/browser/renderer_host/audio_renderer_host_unittest.cc (working copy)
@@ -5,6 +5,7 @@
#include "base/message_loop.h"
#include "base/process_util.h"
#include "base/scoped_ptr.h"
+#include "chrome/browser/chrome_thread.h"
#include "chrome/browser/renderer_host/audio_renderer_host.h"
#include "chrome/common/render_messages.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -29,8 +30,8 @@
class MockAudioRendererHost : public AudioRendererHost {
public:
- MockAudioRendererHost(MessageLoop* loop)
- : AudioRendererHost(loop) {
+ MockAudioRendererHost()
+ : AudioRendererHost() {
}
virtual ~MockAudioRendererHost() {
@@ -120,7 +121,8 @@
virtual void SetUp() {
// Create a message loop so AudioRendererHost can use it.
message_loop_.reset(new MessageLoop(MessageLoop::TYPE_IO));
- host_ = new MockAudioRendererHost(message_loop_.get());
+ io_thread_.reset(new ChromeThread(ChromeThread::IO, message_loop_.get()));
+ host_ = new MockAudioRendererHost();
}
virtual void TearDown() {
@@ -128,11 +130,13 @@
// message_loop_.
host_->Destroy();
+ // Release the reference to the mock object.
+ host_ = NULL;
+
// We need to continue running message_loop_ to complete all destructions.
message_loop_->RunAllPending();
- // Release the reference to the mock object.
- host_ = NULL;
+ io_thread_.reset();
}
AudioRendererHost::IPCAudioSource* CreateAudioStream(
@@ -180,6 +184,7 @@
scoped_ptr<MessageLoop> message_loop_;
private:
+ scoped_ptr<ChromeThread> io_thread_;
DISALLOW_COPY_AND_ASSIGN(AudioRendererHostTest);
};
« no previous file with comments | « chrome/browser/renderer_host/audio_renderer_host.cc ('k') | chrome/browser/renderer_host/browser_render_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698