Issue 354002: Sixth patch in getting rid of caching MessageLoop pointers. Audio and automa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354002: Sixth patch in getting rid of caching MessageLoop pointers. Audio and automa... (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sixth patch in getting rid of caching MessageLoop pointers. BUG=25354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30737

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -62 lines)			Patch
M	chrome/browser/automation/automation_resource_message_filter.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_resource_message_filter.cc	View		7 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/renderer_host/audio_renderer_host.h	View	1 2 3	4 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/audio_renderer_host.cc	View	1 2 3	17 chunks	+30 lines, -33 lines	0 comments	Download
M	chrome/browser/renderer_host/audio_renderer_host_unittest.cc	View	4	5 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

LGTM. One question, what is the intention of removing reference to MessageLoop? Is it that ...

11 years, 1 month ago (2009-11-02 18:52:40 UTC) #2

jam

11 years, 1 month ago (2009-11-02 19:01:08 UTC) #3

On Mon, Nov 2, 2009 at 10:52 AM, <hclam@chromium.org> wrote:

> LGTM.
>
> One question, what is the intention of removing reference to MessageLoop?
> Is it
> that we shouldn't be using MessageLoop directly?

Correct.  I'm sending out an email today to chromium-dev with the nitty
gritty details (perhaps I should have sent it first!).

>
>
> http://codereview.chromium.org/354002
>

Expand Messages | Collapse Messages