net/http/http_stream_factory_impl_unittest.cc - Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comment I missed in the last patch. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/io_thread.cc ('K') | « net/http/http_proxy_client_socket_pool_unittest.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | net/socket/client_socket_pool_manager_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_impl_unittest.cc

diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc

index 924e1c3997624dc62d6fd26e9ce456b85927475f..a2eeeadd250efa3b824634910fbac2ddf2a4d3e9 100644

--- a/net/http/http_stream_factory_impl_unittest.cc

+++ b/net/http/http_stream_factory_impl_unittest.cc

@@ -407,7 +407,7 @@ CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool(

CertVerifier* cert_verifier)

: SSLClientSocketPool(0,

- NULL, // ssl_histograms

+ NULL, // ssl_histograms

host_resolver,

cert_verifier,

NULL, // server_bound_cert_store

@@ -418,9 +418,11 @@ CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool(

NULL, // transport_socket_pool

NULL,

- NULL, // ssl_config_service

- NULL), // net_log

- last_num_streams_(-1) {}

+ NULL, // ssl_config_service

+ false, // enable_ssl_connect_job_waiting

+ NULL), // net_log

wtc 2014/07/23 22:53:32 Please align all the comments. I wonder why "git c

mshelley 2014/07/24 20:37:46 Done.

+ last_num_streams_(-1) {

class HttpStreamFactoryTest : public ::testing::Test,

public ::testing::WithParamInterface<NextProto> {