net/socket/client_socket_pool_manager_impl.h - Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_manager_impl.h

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comment I missed in the last patch. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_stream_factory_impl_unittest.cc ('K') | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/socket/client_socket_pool_manager_impl.cc » ('j') | net/socket/socket_test_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/client_socket_pool_manager_impl.h

diff --git a/net/socket/client_socket_pool_manager_impl.h b/net/socket/client_socket_pool_manager_impl.h

index 06d4d244a369423318038463de54b1b3f4e8501f..ea30fd76e877fa6036c3a7760cca791e9807e11a 100644

--- a/net/socket/client_socket_pool_manager_impl.h

+++ b/net/socket/client_socket_pool_manager_impl.h

@@ -67,6 +67,7 @@ class ClientSocketPoolManagerImpl : public base::NonThreadSafe,

const std::string& ssl_session_cache_shard,

ProxyService* proxy_service,

SSLConfigService* ssl_config_service,

+ bool enable_ssl_connect_job_waiting,

HttpNetworkSession::SocketPoolType pool_type);

virtual ~ClientSocketPoolManagerImpl();

@@ -115,6 +116,7 @@ class ClientSocketPoolManagerImpl : public base::NonThreadSafe,

ProxyService* const proxy_service_;

const scoped_refptr<SSLConfigService> ssl_config_service_;

const HttpNetworkSession::SocketPoolType pool_type_;

+ bool enable_ssl_connect_job_waiting_;

wtc 2014/07/23 22:53:32 Reverse these two fields to match the constructor

mshelley 2014/07/24 20:37:46 Done.

// Note: this ordering is important.