Implements new, more robust design for communicating between SSLConnectJobs.

net/http/http_stream_factory_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 389 matching lines @@
     HostResolver* host_resolver, CertVerifier* /* cert_verifier */)
     : HttpProxyClientSocketPool(0, 0, NULL, host_resolver, NULL, NULL, NULL),
       last_num_streams_(-1) {}
 
 template <>
 CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool(
     HostResolver* host_resolver,
     CertVerifier* cert_verifier)
     : SSLClientSocketPool(0,
                           0,
-                          NULL,           // ssl_histograms
+                          NULL,  // ssl_histograms
                           host_resolver,
                           cert_verifier,
                           NULL,           // server_bound_cert_store
                           NULL,           // transport_security_state
                           NULL,           // cert_transparency_verifier
                           std::string(),  // ssl_session_cache_shard
                           NULL,           // deterministic_socket_factory
                           NULL,           // transport_socket_pool
                           NULL,
                           NULL,
-                          NULL,           // ssl_config_service
-                          NULL),          // net_log
-      last_num_streams_(-1) {}
+                          NULL,   // ssl_config_service
+                          false,  // enable_ssl_connect_job_waiting
+                          NULL),  // net_log

[wtc, 2014/07/23 22:53:32]

Please align all the comments. I wonder why "git cl format" doesn't do this
correctly. Perhaps "git cl format" only aligns the consecutive comments?

[mshelley, 2014/07/24 20:37:46]

Done.

+      last_num_streams_(-1) {
+}
 
 class HttpStreamFactoryTest : public ::testing::Test,
                               public ::testing::WithParamInterface<NextProto> {
 };
 
 INSTANTIATE_TEST_CASE_P(
     NextProto,
     HttpStreamFactoryTest,
     testing::Values(kProtoDeprecatedSPDY2,
                     kProtoSPDY3, kProtoSPDY31, kProtoSPDY4));
@@ skipping 883 matching lines @@
   EXPECT_TRUE(waiter.used_proxy_info().is_direct());
 
   // Make sure there is no orphaned job. it is already canceled.
   ASSERT_EQ(0u, static_cast<HttpStreamFactoryImpl*>(
       session->http_stream_factory_for_websocket())->num_orphaned_jobs());
 }
 
 }  // namespace
 
 }  // namespace net