IDL: Merge duplicating local variable assignment in attribute_getter

IDL: Merge duplicating local variable assignment in attribute_getter

|cpp_type| can be non-*Ptr type so it seems that we can't always use
local variables if we want to merge local variable assignment.
Following Jens' suggestion[1] to merge local variable assignment.

[1] https://codereview.chromium.org/359703002/diff/1/Source/bindings/templates/attributes.cpp#newcode51

BUG=345503
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177090

[bashi, 2014-06-27 08:55:08]

Could you review this?

[haraken, 2014-06-27 09:00:48]

LGTM

https://codereview.chromium.org/351403003/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp (right):

https://codereview.chromium.org/351403003/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp:126:
RefPtr<Uint8Array>
v8Value(impl->initializedByEventConstructorReadonlyUint8ArrayAttribute());

This is not a V8 value. Shall we rename this to cppValue? You can do it in a
follow-up CL.

[Jens Widell, 2014-06-27 09:03:22]

LGTM too. Nice clean-up.

[bashi, 2014-06-27 09:13:31]

Thanks!

https://codereview.chromium.org/351403003/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp (right):

https://codereview.chromium.org/351403003/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp:126:
RefPtr<Uint8Array>
v8Value(impl->initializedByEventConstructorReadonlyUint8ArrayAttribute());
On 2014/06/27 09:00:47, haraken wrote:
> 
> This is not a V8 value. Shall we rename this to cppValue? You can do it in a
> follow-up CL.
> 

Done.

[bashi, 2014-06-27 09:13:34]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-06-27 09:14:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bashi@chromium.org/351403003/20001

[commit-bot: I haz the power, 2014-06-27 09:51:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13078)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14039)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22417)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/26806)

[commit-bot: I haz the power, 2014-06-27 09:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-27 09:58:16]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[bashi, 2014-06-27 10:08:42]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-06-27 10:09:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bashi@chromium.org/351403003/40001

[commit-bot: I haz the power, 2014-06-27 11:13:04]

Change committed as 177090