Source/bindings/scripts/v8_attributes.py - Issue 351403003: IDL: Merge duplicating local variable assignment in attribute_getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 351403003: IDL: Merge duplicating local variable assignment in attribute_getter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Further v8Value -> cppValue renaming Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index be2e12db441ab770159a654f30b13e7f972bb063..8d82ac9f77f32dbab2a052e1fdccf5f4bcbd513f 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -173,9 +173,10 @@ def getter_context(interface, attribute, context):

base_idl_type == 'EventHandler' or

'CachedAttribute' in extended_attributes or

'ReflectOnly' in extended_attributes or

+ context['is_keep_alive_for_gc'] or

context['is_getter_raises_exception']):

context['cpp_value_original'] = cpp_value

- cpp_value = 'v8Value'

+ cpp_value = 'cppValue'

# EventHandler has special handling

if base_idl_type != 'EventHandler' and idl_type.is_interface_type:

release = True

« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »