Source/bindings/tests/results/V8TestInterfaceNode.cpp - Issue 351403003: IDL: Merge duplicating local variable assignment in attribute_getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNode.cpp

Issue 351403003: IDL: Merge duplicating local variable assignment in attribute_getter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Further v8Value -> cppValue renaming Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceNode.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNode.cpp b/Source/bindings/tests/results/V8TestInterfaceNode.cpp

index c0a2179d43e3ee4e5da0a9f7feb904fed3c415b4..270976838351be567bb42d5e34fe38c61c609d26 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNode.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNode.cpp

@@ -94,8 +94,8 @@ static void eventHandlerAttributeAttributeGetter(const v8::PropertyCallbackInfo<

{

v8::Handle<v8::Object> holder = info.Holder();

TestInterfaceNode* impl = V8TestInterfaceNode::toNative(holder);

- EventListener* v8Value = impl->eventHandlerAttribute();

- v8SetReturnValue(info, v8Value ? v8::Handle<v8::Value>(V8AbstractEventListener::cast(v8Value)->getListenerObject(impl->executionContext())) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate())));

+ EventListener* cppValue(impl->eventHandlerAttribute());

+ v8SetReturnValue(info, cppValue ? v8::Handle<v8::Value>(V8AbstractEventListener::cast(cppValue)->getListenerObject(impl->executionContext())) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate())));

}

static void eventHandlerAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)