Issue 350903002: Move validation to validate.dart and add comments.

Issue 350903002: Move validation to validate.dart and add comments. (Closed)

Created:
6 years, 6 months ago by floitsch

Modified:
6 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move validation to validate.dart and add comments. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=37685

Patch Set 3 : Check for critical edges. #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/validate.dart	View	1 2	2 chunks	+21 lines, -1 line	2 comments	Download
M	tests/language/critical_edge2_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/critical_edge_test.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/350903002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart File sdk/lib/_internal/compiler/implementation/ssa/validate.dart (right): https://codereview.chromium.org/350903002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart#newcode41 sdk/lib/_internal/compiler/implementation/ssa/validate.dart:41: if (block.last is HLoopBranch) { Why just limiting ...

6 years, 6 months ago (2014-06-24 15:45:01 UTC) #2

floitsch

PTAL. https://codereview.chromium.org/350903002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart File sdk/lib/_internal/compiler/implementation/ssa/validate.dart (right): https://codereview.chromium.org/350903002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart#newcode41 sdk/lib/_internal/compiler/implementation/ssa/validate.dart:41: if (block.last is HLoopBranch) { On 2014/06/24 15:45:00, ...

6 years, 6 months ago (2014-06-24 18:29:43 UTC) #3

ngeoffray

LGTM https://codereview.chromium.org/350903002/diff/40001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart File sdk/lib/_internal/compiler/implementation/ssa/validate.dart (right): https://codereview.chromium.org/350903002/diff/40001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart#newcode82 sdk/lib/_internal/compiler/implementation/ssa/validate.dart:82: block.last is! HSwitch) { Wow, did not realize ...

6 years, 6 months ago (2014-06-25 07:55:22 UTC) #4

floitsch

https://codereview.chromium.org/350903002/diff/40001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart File sdk/lib/_internal/compiler/implementation/ssa/validate.dart (right): https://codereview.chromium.org/350903002/diff/40001/sdk/lib/_internal/compiler/implementation/ssa/validate.dart#newcode82 sdk/lib/_internal/compiler/implementation/ssa/validate.dart:82: block.last is! HSwitch) { On 2014/06/25 07:55:22, ngeoffray wrote: ...

6 years, 6 months ago (2014-06-25 08:27:18 UTC) #5

floitsch

6 years, 6 months ago (2014-06-25 08:30:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r37685 (presubmit successful).

Expand Messages | Collapse Messages