sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 350903002: Move validation to validate.dart and add comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 350903002: Move validation to validate.dart and add comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Check for critical edges. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/validate.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/validate.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index 70f09a6bdad19131db8f522bcebb0387605bf217..e4848faa8b242b187f8e4dae8cc915a38b41e24c 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -755,12 +755,6 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

HExpressionInformation condition = info.condition;

bool isConditionExpression = isJSCondition(condition);

- // Assert that the block we inserted to avoid critical edges satisfies

- // basic assumptions.

- assert(!condition.end.successors.last.isEmpty);

- assert(condition.end.successors.last.first is HGoto);

- assert(condition.end.successors.last.first.next == null);

js.Loop loop;

switch (info.kind) {

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/validate.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/validate.dart » ('J')