Issue 350293002: [Telemetry] Move supports_tab_control to PossibleBrowser.

Issue 350293002: [Telemetry] Move supports_tab_control to PossibleBrowser. (Closed)

Created:
6 years, 6 months ago by tonyg

Modified:
6 years, 6 months ago

Reviewers:
achuithb, dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Move supports_tab_control to PossibleBrowser. This is in preparation for teaching @test.Enabled/@test.Disabled about browsers that support tab control. BUG=379561 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279644

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -41 lines)			Patch
M	tools/telemetry/telemetry/core/backends/browser_backend.py	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py	View		5 chunks	+1 line, -17 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py	View	1	2 chunks	+4 lines, -4 lines	1 comment	Download
M	tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py	View		1 chunk	+1 line, -1 line	1 comment	Download
M	tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py	View		5 chunks	+6 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/browser.py	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/core/possible_browser.py	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/350293002/20001

6 years, 6 months ago (2014-06-25 02:14:03 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-25 06:41:40 UTC) #5

achuithb

6 years, 6 months ago (2014-06-25 06:55:49 UTC) #7

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/350293002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
(left):

https://codereview.chromium.org/350293002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:260:
return self.chrome_branch_number >= 1303
Awesome! I believe this fixes http://crbug.com/351893

https://codereview.chromium.org/350293002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py
(right):

https://codereview.chromium.org/350293002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py:29:
finder_options, True)
supports_tab_control=True would be more readable here. I guess you were avoiding
mixing positional and keyword arguments?

Expand Messages | Collapse Messages