tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py - Issue 350293002: [Telemetry] Move supports_tab_control to PossibleBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

Issue 350293002: [Telemetry] Move supports_tab_control to PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

index 55e85b2c03283c968efdbfd5153ac67cae1fddac..e26be6adb85c1eb4082650bcfb524d740c8d0a23 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

@@ -35,7 +35,7 @@ class PossibleDesktopBrowser(possible_browser.PossibleBrowser):

is_content_shell, browser_directory, is_local_build=False):

target_os = sys.platform.lower()

super(PossibleDesktopBrowser, self).__init__(browser_type, target_os,

- finder_options)

+ finder_options, not is_content_shell)

assert browser_type in ALL_BROWSER_TYPES, \

'Please add %s to ALL_BROWSER_TYPES' % browser_type

self._local_executable = executable