Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 350293002: [Telemetry] Move supports_tab_control to PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index 3ead0bf9ff7a6e4b51b3035a9d09833821883091..496a257a8ad87d20f28a5b756812910b0af81dd1 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -44,10 +44,6 @@ class AndroidBrowserBackendSettings(object):
sys.exit(1)
@property
- def is_content_shell(self):
- return False
-
- @property
def profile_dir(self):
return '/data/data/%s/' % self.package
@@ -118,10 +114,6 @@ class ContentShellBackendSettings(AndroidBrowserBackendSettings):
def GetDevtoolsRemotePort(self):
return 'localabstract:content_shell_devtools_remote'
- @property
- def is_content_shell(self):
- return True
-
class ChromeShellBackendSettings(AndroidBrowserBackendSettings):
def __init__(self, adb, package):
@@ -136,10 +128,6 @@ class ChromeShellBackendSettings(AndroidBrowserBackendSettings):
def GetDevtoolsRemotePort(self):
return 'localabstract:chrome_shell_devtools_remote'
- @property
- def is_content_shell(self):
- return True
-
class WebviewBackendSettings(AndroidBrowserBackendSettings):
def __init__(self, adb, package):
@@ -179,7 +167,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
def __init__(self, browser_options, backend_settings, use_rndis_forwarder,
output_profile_path, extensions_to_load):
super(AndroidBrowserBackend, self).__init__(
- is_content_shell=backend_settings.is_content_shell,
+ supports_tab_control=backend_settings.supports_tab_control,
supports_extensions=False, browser_options=browser_options,
output_profile_path=output_profile_path,
extensions_to_load=extensions_to_load)
@@ -362,10 +350,6 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
def activity(self):
return self._backend_settings.activity
- @property
- def supports_tab_control(self):
- return self._backend_settings.supports_tab_control
-
def __del__(self):
self.Close()

Powered by Google App Engine
This is Rietveld 408576698