Move allocation of texture from SkGpuDevice to GrLayerCache

Move allocation of texture from SkGpuDevice to GrLayerCache

In order to atlas the layers the GrLayerCache needs to be given more control over where a given layer's texture is allocated (i.e., it could be a raw scratch texture or in the cache).

Committed: https://skia.googlesource.com/skia/+/4ec84da746d66e1bcb76ab2f8b94602b8e966589

[bsalomon, 2014-06-24 17:29:59]

lgtm

https://codereview.chromium.org/350183006/diff/20001/src/gpu/GrLayerCache.h
File src/gpu/GrLayerCache.h (right):

https://codereview.chromium.org/350183006/diff/20001/src/gpu/GrLayerCache.h#n...
src/gpu/GrLayerCache.h:110: // if it was found in the ResourceCache and doesn't
need to be regenerated
Maybe should add something to the comment about the false case. "If false is
returned the caller should render the layer content to the texture to insert the
layer into the cache" or something along those lines.

https://codereview.chromium.org/350183006/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/350183006/diff/20001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:1965: bool bNeedsRendering =
!fContext->getLayerCache()->lock(layer, desc);
b?

[robertphillips, 2014-06-24 19:59:43]

https://codereview.chromium.org/350183006/diff/20001/src/gpu/GrLayerCache.h
File src/gpu/GrLayerCache.h (right):

https://codereview.chromium.org/350183006/diff/20001/src/gpu/GrLayerCache.h#n...
src/gpu/GrLayerCache.h:110: // if it was found in the ResourceCache and doesn't
need to be regenerated
On 2014/06/24 17:29:59, bsalomon wrote:
> Maybe should add something to the comment about the false case. "If false is
> returned the caller should render the layer content to the texture to insert
the
> layer into the cache" or something along those lines.

Done.

https://codereview.chromium.org/350183006/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/350183006/diff/20001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:1965: bool bNeedsRendering =
!fContext->getLayerCache()->lock(layer, desc);
On 2014/06/24 17:29:59, bsalomon wrote:
> b?

Done.

[robertphillips, 2014-06-24 19:59:46]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-06-24 20:00:01]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/350183006/4...

[commit-bot: I haz the power, 2014-06-24 20:10:46]

Change committed as 4ec84da746d66e1bcb76ab2f8b94602b8e966589