Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 349653002: Remove gen/blink/modules from build files since all includes have been qualified. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove gen/blink/modules from build files since all includes have been qualified. BUG=381876 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -26 lines) Patch
M Source/bindings/v8/custom/V8EventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/core.gyp View 2 chunks +1 line, -5 lines 0 comments Download
M Source/modules/EventModules.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/EventTargetModules.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/InitModules.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/modules.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
c.shu
6 years, 6 months ago (2014-06-20 14:25:24 UTC) #1
c.shu
On 2014/06/20 14:25:24, c.shu wrote: The builds are doing fine and the CL is kinda ...
6 years, 6 months ago (2014-06-20 15:11:06 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-20 15:11:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/349653002/1
6 years, 6 months ago (2014-06-20 15:12:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 15:12:10 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-20 15:12:11 UTC) #6
haraken
LGTM
6 years, 6 months ago (2014-06-20 15:21:56 UTC) #7
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-20 15:23:00 UTC) #8
c.shu
On 2014/06/20 15:21:56, haraken wrote: > LGTM saved my day.
6 years, 6 months ago (2014-06-20 15:23:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/349653002/1
6 years, 6 months ago (2014-06-20 15:24:13 UTC) #10
commit-bot: I haz the power
Change committed as 176620
6 years, 6 months ago (2014-06-20 16:07:50 UTC) #11
Nils Barth (inactive)
On 2014/06/20 15:23:21, c.shu wrote: > On 2014/06/20 15:21:56, haraken wrote: > > LGTM > ...
6 years, 6 months ago (2014-06-23 01:20:03 UTC) #12
Nils Barth (inactive)
Thanks Chang!!
6 years, 6 months ago (2014-06-23 01:20:37 UTC) #13
c.shu
On 2014/06/23 01:20:03, Nils Barth wrote: > On 2014/06/20 15:23:21, c.shu wrote: > > On ...
6 years, 6 months ago (2014-06-23 14:02:19 UTC) #14
Nils Barth (inactive)
6 years, 6 months ago (2014-06-24 01:36:35 UTC) #15
Message was sent while issue was closed.
On 2014/06/23 14:02:19, c.shu wrote:
> Thanks, Nils. I have not officially been a committer so TBR is not allowed. :(
> Hopefully tomorrow the paperwork will go through.

Oops, forgot about that.
Hope things go smoothly and enjoy your new-found powers!

Powered by Google App Engine
This is Rietveld 408576698