Source/core/BUILD.gn - Issue 349653002: Remove gen/blink/modules from build files since all includes have been qualified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/BUILD.gn

Issue 349653002: Remove gen/blink/modules from build files since all includes have been qualified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/BUILD.gn

diff --git a/Source/core/BUILD.gn b/Source/core/BUILD.gn

index 30befbf7ae7b95e611a37be80b873831370559f2..0d94501a798d78ee1581e3d1dc9bcc8f0c2500b2 100644

--- a/Source/core/BUILD.gn

+++ b/Source/core/BUILD.gn

@@ -41,15 +41,10 @@ config("core_include_dirs") {

include_dirs = [

"..",

"../..",

- # FIXME: Remove these once core scripts generates qualified

+ # FIXME: Remove two lines below once core scripts generates qualified

# includes correctly: http://crbug.com/358074

- blink_modules_output_dir,

bindings_core_v8_output_dir,

bindings_modules_v8_output_dir,

- # FIXME: MediaQueryListListener.cpp includes

- # "gen/blink/bindings/core/v8/V8MediaQueryList.h" relative to "gen/blink"

- # which is busted. This file (and any other ones that do a similar thing)

- # should be fixed and this can be removed.

"$root_gen_dir/blink",

]

if (is_android && use_openmax_dl_fft) {

« no previous file with comments | « Source/bindings/v8/custom/V8EventCustom.cpp ('k') | Source/core/core.gyp » ('j') | no next file with comments »