Source/core/core.gyp - Issue 349653002: Remove gen/blink/modules from build files since all includes have been qualified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/core.gyp

Issue 349653002: Remove gen/blink/modules from build files since all includes have been qualified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/core.gyp

diff --git a/Source/core/core.gyp b/Source/core/core.gyp

index ddaa1d2979f78b203c6304fef2ac74274947e66f..1d6d0c620653127b571bb555ba9d579ded1b187a 100644

--- a/Source/core/core.gyp

+++ b/Source/core/core.gyp

@@ -35,8 +35,6 @@

'../build/scripts/scripts.gypi',

'../bindings/core/core.gypi', # core can depend on bindings/core, but not on bindings

'core.gypi',

- '../modules/modules_generated.gypi', # FIXME: Required by <(blink_modules_output_dir) below.

- '../platform/platform_generated.gypi', # FIXME: Required by <(blink_platform_output_dir) below.

'variables': {

@@ -44,12 +42,10 @@

'webcore_include_dirs': [

'..', # WebKit/Source

- # FIXME: Remove these once core scripts generate qualified

+ # FIXME: Remove the following two lines once core scripts generate qualified

# includes correctly: http://crbug.com/380054

- '<(blink_modules_output_dir)',

'<(bindings_core_v8_output_dir)',

'<(bindings_modules_v8_output_dir)',

- # Needed to include the generated binding headers.

'<(SHARED_INTERMEDIATE_DIR)/blink', # gen/blink

« no previous file with comments | « Source/core/BUILD.gn ('k') | Source/modules/EventModules.h » ('j') | no next file with comments »