Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 348933002: Show an error message when the user tries to set the commit flag or add trybots to a private issue. (Closed)

Created:
6 years, 6 months ago by jrobbins
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Show an error message when the user tries to set the commit flag or add trybots to a private issue. BUG=387088 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=279514

Patch Set 1 #

Total comments: 2

Patch Set 2 : added check for private issues to gcl.py for try jobs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M gcl.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M git_cl.py View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jrobbins
PTAL. I am also sending you a separate CL for the server-side.
6 years, 6 months ago (2014-06-20 22:40:41 UTC) #1
sheyang
One comment. https://codereview.chromium.org/348933002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/348933002/diff/1/git_cl.py#newcode2270 git_cl.py:2270: props = cl.GetIssueProperties() Need to update gcl ...
6 years, 6 months ago (2014-06-20 23:08:03 UTC) #2
Jason Robbins -- corp
https://codereview.chromium.org/348933002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/348933002/diff/1/git_cl.py#newcode2270 git_cl.py:2270: props = cl.GetIssueProperties() On 2014/06/20 23:08:03, sheyang wrote: > ...
6 years, 6 months ago (2014-06-20 23:46:21 UTC) #3
Jason Robbins -- corp
On 2014/06/20 23:46:21, Jason Robbins (corp) wrote: > https://codereview.chromium.org/348933002/diff/1/git_cl.py > File git_cl.py (right): > > ...
6 years, 6 months ago (2014-06-23 19:20:03 UTC) #4
sheyang
lgtm
6 years, 6 months ago (2014-06-23 20:31:18 UTC) #5
Jason Robbins -- corp
The CQ bit was checked by jrobbins@google.com
6 years, 6 months ago (2014-06-23 20:37:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrobbins@chromium.org/348933002/20001
6 years, 6 months ago (2014-06-23 20:38:08 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 20:38:09 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-23 20:38:10 UTC) #9
Jason Robbins -- corp
iannucci, can you approve this one too?
6 years, 6 months ago (2014-06-23 20:44:43 UTC) #10
iannucci
lgtm
6 years, 6 months ago (2014-06-24 19:00:25 UTC) #11
Jason Robbins -- corp
The CQ bit was checked by jrobbins@google.com
6 years, 6 months ago (2014-06-24 22:10:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrobbins@chromium.org/348933002/20001
6 years, 6 months ago (2014-06-24 22:12:00 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 22:14:37 UTC) #14
Message was sent while issue was closed. 
Change committed as 279514

Powered by Google App Engine
This is Rietveld 408576698