Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: gcl.py

Issue 348933002: Show an error message when the user tries to set the commit flag or add trybots to a private issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: added check for private issues to gcl.py for try jobs Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 1502c061effe99e4b16cf2c2a0de0bd384f1ad4b..f6bb85286f5fc131fab9e97b046425e12389a417 100755
--- a/gcl.py
+++ b/gcl.py
@@ -1367,6 +1367,12 @@ def CMDtry(args):
else:
change_info = ChangeInfo.Load(args[0], GetRepositoryRoot(),
True, True)
+
+ props = change_info.RpcServer().get_issue_properties(
+ change_info.issue, False)
+ if props.get('private'):
+ ErrorExit('Cannot use trybots on a private issue')
+
if change_info.GetFiles():
args = args[1:]
else:
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698