Show an error message when the user tries to set the commit flag or add trybots to a private issue.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import datetime
@@ skipping 2249 matching lines @@
   parser.add_option_group(group)
   options, args = parser.parse_args(args)
 
   if args:
     parser.error('Unknown arguments: %s' % args)
 
   cl = Changelist()
   if not cl.GetIssue():
     parser.error('Need to upload first')
 
+  props = cl.GetIssueProperties()

[sheyang, 2014/06/20 23:08:03]

Need to update gcl as well?

[Jason Robbins -- corp, 2014/06/20 23:46:21]

Yeah, I guess I need to add logic there too.  I'll upload a new patchset
tomorrow.

+  if props.get('private'):
+    parser.error('Cannot use trybots with private issue')
+
   if not options.name:
     options.name = cl.GetBranch()
 
   if options.bot and not options.master:
     parser.error('For manually specified bots please also specify the '
                  'tryserver master, e.g. "-m tryserver.chromium".')
 
   def GetMasterMap():
     # Process --bot and --testfilter.
     if not options.bot:
@@ skipping 125 matching lines @@
   webbrowser.open(issue_url)
   return 0
 
 
 def CMDset_commit(parser, args):
   """Sets the commit bit to trigger the Commit Queue."""
   _, args = parser.parse_args(args)
   if args:
     parser.error('Unrecognized args: %s' % ' '.join(args))
   cl = Changelist()
+  props = cl.GetIssueProperties()
+  if props.get('private'):
+    parser.error('Cannot set commit on private issue')
   cl.SetFlag('commit', '1')
   return 0
 
 
 def CMDset_close(parser, args):
   """Closes the issue."""
   _, args = parser.parse_args(args)
   if args:
     parser.error('Unrecognized args: %s' % ' '.join(args))
   cl = Changelist()
@@ skipping 200 matching lines @@
         ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
           'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
 
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   sys.exit(main(sys.argv[1:]))