Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 346603007: Remove position: sticky (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, blink-layers+watch_chromium.org, caseq+blink_chromium.org, chromiumbugtracker_adobe.com, malch+blink_chromium.org, blink-reviews-css, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rwlbuis, kenneth.christiansen, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-rendering, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, sergeyv+blink_chromium.org, eseidel, jamesr, ojan, ostap
Project:
blink
Visibility:
Public.

Description

Remove position: sticky We would eventually like to implement position: sticky, but the current implementation isn't designed in a way that integrates well with the existing scrolling and compositing system. For example, position: sticky relies upon updateLayerPositionsAfterDocumentScroll to function correctly, but that function has no other purpose and can otherwise be removed. Similarly, position: sticky doesn't work at all with composited overflow scrolling, which is now the default mechanism for driving scrolling in the engine. Once we've got our scrolling and compositing house in order, we should return to position: sticky and implement the feature in a way that integrates well with the rest of the engine. For now, however, this CL removes our current implementation so we can focus on improving our implementation of the scrolling features we've already shipped. R=eseidel@chromium.org, esprehn@chromium.org BUG=389638, 231752 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4619 lines) Patch
M LayoutTests/StaleTestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/css/sticky/inflow-sticky.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/css/sticky/inflow-sticky-expected.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/fast/css/sticky/inline-sticky.html View 1 chunk +0 lines, -86 lines 0 comments Download
D LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html View 1 chunk +0 lines, -93 lines 0 comments Download
D LayoutTests/fast/css/sticky/inline-sticky-abspos-child-expected.html View 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/fast/css/sticky/inline-sticky-expected.html View 1 chunk +0 lines, -76 lines 0 comments Download
D LayoutTests/fast/css/sticky/parsing-position-sticky.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/css/sticky/parsing-position-sticky-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/css/sticky/remove-inline-sticky-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/css/sticky/remove-sticky-crash.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/css/sticky/remove-sticky-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/css/sticky/replaced-sticky.html View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/fast/css/sticky/replaced-sticky-expected.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/fast/css/sticky/resources/parsing-position-sticky.js View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-as-positioning-container.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-as-positioning-container-expected.html View 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-both-sides.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-both-sides-expected.html View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding.html View 1 chunk +0 lines, -90 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding-expected.html View 1 chunk +0 lines, -90 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-display.html View 1 chunk +0 lines, -92 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-display-expected.html View 1 chunk +0 lines, -92 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-flexbox.html View 1 chunk +0 lines, -93 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-flexbox-expected.html View 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-grid.html View 1 chunk +0 lines, -92 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-grid-expected.html View 1 chunk +0 lines, -81 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-ltr.html View 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-ltr-expected.html View 1 chunk +0 lines, -76 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl-expected.html View 1 chunk +0 lines, -77 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-left.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-left-expected.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-margins.html View 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-margins-expected.html View 1 chunk +0 lines, -76 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-overflowing.html View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-overflowing-expected.html View 1 chunk +0 lines, -64 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-side-margins.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-side-margins-expected.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-stacking-context.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-stacking-context-expected.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-table-col-crash.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-table-col-crash-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-table-row-top.html View 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-table-thead-top.html View 1 chunk +0 lines, -111 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top.html View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-expected.html View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-margins.html View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-margins-expected.html View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-overflow.html View 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-overflow-expected.html View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html View 1 chunk +0 lines, -104 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment-expected.html View 1 chunk +0 lines, -81 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-zoomed.html View 1 chunk +0 lines, -80 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-top-zoomed-expected.html View 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-vertically-overconstrained.html View 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-vertically-overconstrained-expected.html View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-writing-mode-horizontal-bt.html View 1 chunk +0 lines, -66 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-writing-mode-horizontal-bt-expected.html View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr-expected.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl-expected.html View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingConstraints.h View 2 chunks +2 lines, -76 lines 0 comments Download
M Source/core/page/scrolling/ScrollingConstraints.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M Source/core/rendering/LayoutState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 3 chunks +3 lines, -116 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 6 chunks +6 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/layers/LayerDetailsView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 5 months ago (2014-06-27 18:45:43 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-06-27 19:17:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/346603007/1
6 years, 5 months ago (2014-06-27 19:18:19 UTC) #3
abarth-chromium
6 years, 5 months ago (2014-06-27 20:33:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r177128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698