Issue 346543003: Remove WebLockOrientationCallback::ErrorType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346543003: Remove WebLockOrientationCallback::ErrorType (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 6 months ago

Reviewers:
tkent, abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr

Base URL:
https://chromium.googlesource.com/chromium/blink.git@split_up_callback_errors

Project:
blink

Visibility:
Public.

Remove WebLockOrientationCallback::ErrorType This is deprecated and WebLockOrientationError should be used. BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176756

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -35 lines)			Patch
M	Source/modules/screen_orientation/LockOrientationCallback.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/screen_orientation/LockOrientationCallback.cpp	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	public/platform/WebLockOrientationCallback.h	View	1 chunk	+1 line, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

mlamouri (slow - plz ping)

This should land after: https://codereview.chromium.org/332493003/ and: https://codereview.chromium.org/347553002/

6 years, 6 months ago (2014-06-18 13:24:24 UTC) #1

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 6 months ago (2014-06-23 13:32:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/346543003/1

6 years, 6 months ago (2014-06-23 13:33:35 UTC) #4

Message was sent while issue was closed.

Change committed as 176756