Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: Source/modules/screen_orientation/LockOrientationCallback.cpp

Issue 346543003: Remove WebLockOrientationCallback::ErrorType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_up_callback_errors
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/screen_orientation/LockOrientationCallback.h" 6 #include "modules/screen_orientation/LockOrientationCallback.h"
7 7
8 #include "bindings/v8/ScriptPromiseResolverWithContext.h" 8 #include "bindings/v8/ScriptPromiseResolverWithContext.h"
9 #include "core/dom/DOMException.h" 9 #include "core/dom/DOMException.h"
10 #include "core/dom/ExceptionCode.h" 10 #include "core/dom/ExceptionCode.h"
(...skipping 11 matching lines...) Expand all
22 } 22 }
23 23
24 void LockOrientationCallback::onSuccess(unsigned angle, blink::WebScreenOrientat ionType type) 24 void LockOrientationCallback::onSuccess(unsigned angle, blink::WebScreenOrientat ionType type)
25 { 25 {
26 // FIXME: for the moment, we do nothing with the angle, we should use it and 26 // FIXME: for the moment, we do nothing with the angle, we should use it and
27 // convert it to the appropriate type if the type == 'undefined' when the 27 // convert it to the appropriate type if the type == 'undefined' when the
28 // method will be implemented in ScreenOrientationController. 28 // method will be implemented in ScreenOrientationController.
29 m_resolver->resolve(ScreenOrientation::orientationTypeToString(type)); 29 m_resolver->resolve(ScreenOrientation::orientationTypeToString(type));
30 } 30 }
31 31
32 void LockOrientationCallback::onError(ErrorType error)
33 {
34 ExceptionCode code = 0;
35 String msg = "";
36
37 switch (error) {
38 case ErrorTypeNotAvailable:
39 code = NotSupportedError;
40 msg = "lockOrientation() is not available on this device.";
41 break;
42 case ErrorTypeFullScreenRequired:
43 code = SecurityError;
44 msg = "The page needs to be fullscreen in order to call lockOrientation( ).";
45 break;
46 case ErrorTypeCanceled:
47 code = AbortError;
48 msg = "A call to lockOrientation() or unlockOrientation() canceled this call.";
49 break;
50 }
51
52 m_resolver->reject(DOMException::create(code, msg));
53 }
54
55 void LockOrientationCallback::onError(blink::WebLockOrientationError error) 32 void LockOrientationCallback::onError(blink::WebLockOrientationError error)
56 { 33 {
57 ExceptionCode code = 0; 34 ExceptionCode code = 0;
58 String msg = ""; 35 String msg = "";
59 36
60 switch (error) { 37 switch (error) {
61 case blink::WebLockOrientationErrorNotAvailable: 38 case blink::WebLockOrientationErrorNotAvailable:
62 code = NotSupportedError; 39 code = NotSupportedError;
63 msg = "lockOrientation() is not available on this device."; 40 msg = "lockOrientation() is not available on this device.";
64 break; 41 break;
65 case blink::WebLockOrientationErrorFullScreenRequired: 42 case blink::WebLockOrientationErrorFullScreenRequired:
66 code = SecurityError; 43 code = SecurityError;
67 msg = "The page needs to be fullscreen in order to call lockOrientation( )."; 44 msg = "The page needs to be fullscreen in order to call lockOrientation( ).";
68 break; 45 break;
69 case blink::WebLockOrientationErrorCanceled: 46 case blink::WebLockOrientationErrorCanceled:
70 code = AbortError; 47 code = AbortError;
71 msg = "A call to lockOrientation() or unlockOrientation() canceled this call."; 48 msg = "A call to lockOrientation() or unlockOrientation() canceled this call.";
72 break; 49 break;
73 } 50 }
74 51
75 m_resolver->reject(DOMException::create(code, msg)); 52 m_resolver->reject(DOMException::create(code, msg));
76 } 53 }
77 54
78 } // namespace WebCore 55 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.h ('k') | public/platform/WebLockOrientationCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698