Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1774)

Unified Diff: public/platform/WebLockOrientationCallback.h

Issue 346543003: Remove WebLockOrientationCallback::ErrorType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_up_callback_errors
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebLockOrientationCallback.h
diff --git a/public/platform/WebLockOrientationCallback.h b/public/platform/WebLockOrientationCallback.h
index fcfbc75780fb020a66eb2b6f028a659cafd80a91..73cb686635d14591ab6e4a943c90101112e74352 100644
--- a/public/platform/WebLockOrientationCallback.h
+++ b/public/platform/WebLockOrientationCallback.h
@@ -17,20 +17,10 @@ namespace blink {
// failure.
class WebLockOrientationCallback {
public:
- enum ErrorType {
- ErrorTypeNotAvailable, // If locking isn't available on the platform.
- ErrorTypeFullScreenRequired, // If fullscreen is required to lock.
- ErrorTypeCanceled, // If another lock/unlock got called before that one ended.
- };
-
virtual ~WebLockOrientationCallback() { }
virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;
-
- // FIXME: those methods are defined and not virtual pure to not break the
- // embedder during the transition period.
- virtual void onError(ErrorType) { }
- virtual void onError(WebLockOrientationError) { }
+ virtual void onError(WebLockOrientationError) = 0;
};
} // namespace blink
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698