chrome/common/extensions/api/input_ime.json - Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/input_ime.json

Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make keyCode attribute optional, and fix tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_engine_interface.h ('K') | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/input_ime.json

diff --git a/chrome/common/extensions/api/input_ime.json b/chrome/common/extensions/api/input_ime.json

index e682d40b82f5dd438f403d95d71594815730d05c..f3a0491a0d5c9a711799e9319369e6def2678de3 100644

--- a/chrome/common/extensions/api/input_ime.json

+++ b/chrome/common/extensions/api/input_ime.json

@@ -18,6 +18,7 @@

"extensionId": {"type": "string", "optional": true, "description": "The extension ID of the sender of this keyevent."},

"key": {"type": "string", "description": "Value of the key being pressed"},

"code": {"type": "string", "description": "Value of the physical key being pressed. The value is not affected by current keyboard layout or modifier state."},

+ "keyCode": {"type": "integer", "optional": true, "description": "It holds system- and implementation-dependent numerical code signifying the unmodified identifier associated with the key pressed."},

"altKey": {"type": "boolean", "optional": true, "description": "Whether or not the ALT key is pressed."},

"ctrlKey": {"type": "boolean", "optional": true, "description": "Whether or not the CTRL key is pressed."},

"shiftKey": {"type": "boolean", "optional": true, "description": "Whether or not the SHIFT key is pressed."},

« chrome/browser/chromeos/input_method/input_method_engine_interface.h ('K') | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | no next file » | no next file with comments »