chrome/browser/extensions/api/input_ime/input_ime_api.cc - Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api.cc

Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make keyCode attribute optional, and fix tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_engine_interface.h ('K') | « chrome/browser/chromeos/input_method/input_method_engine_interface.h ('k') | chrome/common/extensions/api/input_ime.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/input_ime/input_ime_api.cc

diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.cc b/chrome/browser/extensions/api/input_ime/input_ime_api.cc

index f37bac06510c38e288f76d5b5e8783f448c3d15e..2ae8213740bad1be5763c555282ca790d3e47f4f 100644

--- a/chrome/browser/extensions/api/input_ime/input_ime_api.cc

+++ b/chrome/browser/extensions/api/input_ime/input_ime_api.cc

@@ -552,6 +552,7 @@ bool InputImeSendKeyEventsFunction::RunAsync() {

event.type = input_ime::KeyboardEvent::ToString(key_data[i]->type);

event.key = key_data[i]->key;

event.code = key_data[i]->code;

+ event.key_code = key_data[i]->key_code.get() ? *(key_data[i]->key_code) : 0;

if (key_data[i]->alt_key)

event.alt_key = *(key_data[i]->alt_key);

if (key_data[i]->ctrl_key)