chrome/browser/chromeos/input_method/input_method_engine_interface.h - Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_interface.h

Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make keyCode attribute optional, and fix tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc ('k') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_interface.h

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_interface.h b/chrome/browser/chromeos/input_method/input_method_engine_interface.h

index 67a972cab03238b7c81eebea42c946ac9572c77c..ec01921026da7b6070ceee657d42df34a68f397f 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_interface.h

+++ b/chrome/browser/chromeos/input_method/input_method_engine_interface.h

@@ -9,6 +9,7 @@

#include <vector>

#include "ui/base/ime/chromeos/ime_bridge.h"

+#include "ui/events/keycodes/keyboard_codes.h"

Seigo Nonaka 2014/06/20 03:16:02 nit: Do you need this header in header file? If no

Shu Chen 2014/06/20 06:11:58 Done.

class GURL;

@@ -30,6 +31,7 @@ class InputMethodEngineInterface : public IMEEngineHandlerInterface {

std::string type;

std::string key;

std::string code;

+ int key_code; // only used by on-screen keyboards.

std::string extension_id;

bool alt_key;

bool ctrl_key;