Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 345883004: IDL: Use V8StringResource<WithNullCheck> for nullable DOMString (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Use V8StringResource<WithNullCheck> for nullable DOMString For methods this means that the two methods void f(DOMString? arg) void g([TreatNullAs=NullString] DOMString arg) behave the same. Before this fix, the nullability of f()'s argument was simply ignored. For attributes this means that the C++ setter is called with a null string if a null value is assigned to the attribute. There are no CG changes since there are neither nullable string arguments nor writable nullable string attributes in our IDL files. There are such things in specifications, so supporting this is meaningful. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
PTAL
6 years, 6 months ago (2014-06-26 15:55:28 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-26 15:58:09 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-26 16:08:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/345883004/1
6 years, 6 months ago (2014-06-26 16:10:45 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 17:17:09 UTC) #5
Message was sent while issue was closed.
Change committed as 176998

Powered by Google App Engine
This is Rietveld 408576698