Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 345883004: IDL: Use V8StringResource<WithNullCheck> for nullable DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 9ea299c891e8cd5d70b5a98f93888c3aac1ca2c8..ce42700f4db901c561d43bb0f4b07a71c3ea77a2 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -1541,7 +1541,7 @@ static void stringOrNullAttributeAttributeSetter(v8::Local<v8::Value> v8Value, c
{
v8::Handle<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toNative(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ TOSTRING_VOID(V8StringResource<WithNullCheck>, cppValue, v8Value);
impl->setStringOrNullAttribute(cppValue);
}
@@ -7029,7 +7029,7 @@ static void voidMethodDefaultFalseBooleanArgMethodCallback(const v8::FunctionCal
static void voidMethodDefaultNullableByteStringArgMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObject* impl = V8TestObject::toNative(info.Holder());
- V8StringResource<> defaultStringArg;
+ V8StringResource<WithNullCheck> defaultStringArg;
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
@@ -7052,7 +7052,7 @@ static void voidMethodDefaultNullableByteStringArgMethodCallback(const v8::Funct
static void voidMethodDefaultNullableStringArgMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObject* impl = V8TestObject::toNative(info.Holder());
- V8StringResource<> defaultStringArg;
+ V8StringResource<WithNullCheck> defaultStringArg;
{
if (info.Length() > 0) {
TOSTRING_VOID_INTERNAL(defaultStringArg, info[0]);
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698