Source/bindings/scripts/v8_types.py - Issue 345883004: IDL: Use V8StringResource<WithNullCheck> for nullable DOMString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 345883004: IDL: Use V8StringResource<WithNullCheck> for nullable DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index d225d5b1d570cd7a6820d98558c48639db4b8462..9630d71ecc864d91d765d02e7d8336c34e4e7976 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -137,6 +137,8 @@ def cpp_type(idl_type, extended_attributes=None, raw_type=False, used_as_argumen

bool, True if the C++ type is used as an element of an array or sequence.

"""

def string_mode():

+ if idl_type.is_nullable:

+ return 'WithNullCheck'

# FIXME: the Web IDL spec requires 'EmptyString', not 'NullString',

# but we use NullString for performance.

if extended_attributes.get('TreatNullAs') != 'NullString':

« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »