Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 345553003: Support serialization in SkRecord-backed SkPictures. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Support serialization in SkRecord-backed SkPictures. Update DM to test SkRecord through SkPictureRecorder API. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7373456679b809d4e7649a438f0fe5b59257e4e5

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 6

Patch Set 3 : robert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -152 lines) Patch
M dm/DMCpuGMTask.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
D dm/DMRecordTask.h View 1 chunk +0 lines, -39 lines 0 comments Download
D dm/DMRecordTask.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M dm/DMReplayTask.h View 2 chunks +2 lines, -1 line 0 comments Download
M dm/DMReplayTask.cpp View 1 2 3 chunks +11 lines, -13 lines 0 comments Download
M dm/DMSKPTask.h View 1 chunk +2 lines, -2 lines 0 comments Download
M dm/DMSKPTask.cpp View 1 chunk +43 lines, -7 lines 0 comments Download
M dm/DMSerializeTask.h View 1 chunk +7 lines, -1 line 0 comments Download
M dm/DMSerializeTask.cpp View 1 2 3 chunks +15 lines, -5 lines 0 comments Download
M dm/DMUtil.h View 2 chunks +4 lines, -4 lines 0 comments Download
M dm/DMUtil.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M gyp/dm.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 1 4 chunks +35 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 6 months ago (2014-06-24 17:51:13 UTC) #1
robertphillips
lgtm + nits/suggestions https://codereview.chromium.org/345553003/diff/20001/dm/DMReplayTask.cpp File dm/DMReplayTask.cpp (right): https://codereview.chromium.org/345553003/diff/20001/dm/DMReplayTask.cpp#newcode49 dm/DMReplayTask.cpp:49: switch (fMode) { if (!*) { ...
6 years, 6 months ago (2014-06-24 18:34:46 UTC) #2
mtklein
https://codereview.chromium.org/345553003/diff/20001/dm/DMReplayTask.cpp File dm/DMReplayTask.cpp (right): https://codereview.chromium.org/345553003/diff/20001/dm/DMReplayTask.cpp#newcode49 dm/DMReplayTask.cpp:49: switch (fMode) { On 2014/06/24 18:34:46, robertphillips wrote: > ...
6 years, 6 months ago (2014-06-24 19:17:03 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-24 19:17:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/345553003/30001
6 years, 6 months ago (2014-06-24 19:17:51 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 19:28:38 UTC) #6
Message was sent while issue was closed.
Change committed as 7373456679b809d4e7649a438f0fe5b59257e4e5

Powered by Google App Engine
This is Rietveld 408576698