Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: dm/DMReplayTask.cpp

Issue 345553003: Support serialization in SkRecord-backed SkPictures. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: robert Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMReplayTask.h ('k') | dm/DMSKPTask.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMReplayTask.cpp
diff --git a/dm/DMReplayTask.cpp b/dm/DMReplayTask.cpp
index 86838795d26d0929c4d092c4e6ca00070bf77fce..7fd58cef6a4cf777ab789366aa80bb005e86f090 100644
--- a/dm/DMReplayTask.cpp
+++ b/dm/DMReplayTask.cpp
@@ -8,6 +8,10 @@
DEFINE_bool(replay, true, "If true, run picture replay tests.");
DEFINE_bool(rtree, true, "If true, run picture replay tests with an rtree.");
+DEFINE_bool(skr, true, "If true, run picture replay tests with SkRecord backend.");
+
+static const char* kSuffixes[] = { "replay", "rtree", "skr" };
+static const bool* kEnabled[] = { &FLAGS_replay, &FLAGS_rtree, &FLAGS_skr };
namespace DM {
@@ -16,22 +20,23 @@ ReplayTask::ReplayTask(const Task& parent,
SkBitmap reference,
Mode mode)
: CpuTask(parent)
- , fUseRTree(mode == kRTree_Mode)
- , fName(UnderJoin(parent.name().c_str(), fUseRTree ? "rtree" : "replay"))
+ , fMode(mode)
+ , fName(UnderJoin(parent.name().c_str(), kSuffixes[mode]))
, fGM(gm)
, fReference(reference)
{}
void ReplayTask::draw() {
SkAutoTDelete<SkBBHFactory> factory;
- if (fUseRTree) {
+ if (kRTree_Mode == fMode) {
factory.reset(SkNEW(SkRTreeFactory));
}
- SkAutoTUnref<SkPicture> recorded(RecordPicture(fGM.get(), 0, factory.get()));
+ SkAutoTUnref<SkPicture> recorded(
+ RecordPicture(fGM.get(), factory.get(), kSkRecord_Mode == fMode));
SkBitmap bitmap;
AllocatePixels(fReference, &bitmap);
- DrawPicture(recorded, &bitmap);
+ DrawPicture(*recorded, &bitmap);
if (!BitmapsEqual(bitmap, fReference)) {
this->fail();
this->spawnChild(SkNEW_ARGS(WriteTask, (*this, bitmap)));
@@ -42,14 +47,7 @@ bool ReplayTask::shouldSkip() const {
if (fGM->getFlags() & skiagm::GM::kSkipPicture_Flag) {
return true;
}
-
- if (FLAGS_rtree && fUseRTree) {
- return false;
- }
- if (FLAGS_replay && !fUseRTree) {
- return false;
- }
- return true;
+ return !*kEnabled[fMode];
}
} // namespace DM
« no previous file with comments | « dm/DMReplayTask.h ('k') | dm/DMSKPTask.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698