Issue 345083002: Stop referencing gl_FragCoord z and w components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345083002: Stop referencing gl_FragCoord z and w components. (Closed)

Created:
6 years, 6 months ago by bsalomon

Modified:
6 years, 6 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Stop referencing gl_FragCoord z and w components. This fixes an Adreno driver bug where GL programs fail to link if the FS refers to these components of gl_FragCoord. Committed: https://skia.googlesource.com/skia/+/160a52ba217012ed73c240f6d67b3bbf2b4879d6

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	src/effects/SkBlurMaskFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrDitherEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrOvalEffect.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrRRectEffect.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

bsalomon

This works around the Adreno/KitKat driver bug that was causing our GL programs to not ...

6 years, 6 months ago (2014-06-20 13:26:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/345083002/20001

6 years, 6 months ago (2014-06-20 14:09:42 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-20 14:25:19 UTC) #5

Message was sent while issue was closed.

Change committed as 160a52ba217012ed73c240f6d67b3bbf2b4879d6